Bento onboarding splash screen#2125
Merged
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/code/src/renderer/features/onboarding/components/FeatureBentoCard.tsx:35
Double space in class string when `active` is false. The template literal concatenates an empty string for the inactive case and then the `className` prop, producing `"feature-bento-card col-span-4"` (two spaces). While browsers normalise this, the project rule asks us to avoid double spaces from conditional string concatenation.
```suggestion
className={`feature-bento-card${active ? " feature-bento-card--active" : ""} ${className}`}
```
### Issue 2 of 2
apps/code/src/renderer/features/onboarding/components/FeatureBentoCard.tsx:46-54
The `Flex` wrapper around the icon only ever contains a single child (`div.feature-bento-card__icon`), so `gap="2"` and `direction="column"` are superfluous — they have no visible effect. Following the simplicity rule of "no superfluous parts", these props can be dropped.
```suggestion
<Flex
align="center"
justify="center"
className="relative z-10 text-(--gray-9)"
>
<div className="feature-bento-card__icon">{icon}</div>
</Flex>
```
Reviews (1): Last reviewed commit: "Hide placeholder label" | Re-trigger Greptile |
Contributor
|
SEXYYYYYY |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/FeatureBentoCard.tsx:46-50
The `text-(--gray-9)` class on the `Flex` wrapper is dead code — it sets `color: var(--gray-9)` on the container, but the child `div.feature-bento-card__icon` immediately overrides it with `color: var(--gray-12)` (and on hover/active, `color: var(--accent-11)`). The icon SVG inherits from the `div`, so `--gray-9` is never actually applied. Removing it satisfies the "no superfluous parts" simplicity rule.
```suggestion
<Flex
align="center"
justify="center"
className="relative z-10"
>
```
Reviews (2): Last reviewed commit: "Update apps/code/src/renderer/features/o..." | Re-trigger Greptile |
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
…entoCard.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…entoCard.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
… secondary Signals inbox is not enabled by default for the next few weeks; pitching it as the hero card oversells a feature users can't immediately try. Promoting 'Product data as context' (available out of the box) to the hero slot keeps the splash honest until inbox is on by default. Generated-By: PostHog Code Task-Id: c5674c04-c95c-4bfe-bfcf-248a921b4aae
aa9362d to
4179a18
Compare
Move the separator space out of the ternary so Biome's class-sorter sees a clean single-class literal. Output is unchanged. Generated-By: PostHog Code Task-Id: c5674c04-c95c-4bfe-bfcf-248a921b4aae
The grid's overflow-y-auto was triggering a transient scrollbar while cards animated from y:12 to y:0. The wrapping flex column already clips overflow, so dropping the grid's own scroll is safe. Generated-By: PostHog Code Task-Id: c5674c04-c95c-4bfe-bfcf-248a921b4aae
charlesvien
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I've watched 3 people onboard to PH Code in person with the current splash screen below – which is already better than before, but still each person broadly went past this without much understanding. Just results in our points - including the self-driving angle - landing weakly in the product itself (whereas posthog.com/code actually seems quite clear).
I feel very much this comes down to the intro being this raw list - it doesn't have anchor points for scanning.
Changes
Screenshots tell a thousand words, so proposing we turn this into a bento-like splash screen. Crucially, screenshots coming in a follow-up (I'll need you guys to add some in @PostHog/team-code). Here, setting the stage with the sleek layout.
(also, tweaked the headline at the top so the font is exactly aligned with the logo)